DRAFT: trying to make add safe #192
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keepsimple1
commented
Feb 15, 2024
| let rawfd = fd.as_raw_fd(); | ||
|
|
||
| // SAFETY: `rawfd` is valid as it is from `BorrowedFd`. And | ||
| // this block never closes / deletes `rawfd`. |
Author
There was a problem hiding this comment.
Does this comment make sense at all? I'm new to I/O safety, please advise.
Member
|
I don't think it's possible to make |
Author
What if we change Line 174 in 0b4afca
Is it this one? (seems it is still / already safe?) Line 102 in 0b4afca |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To follow up on the issue #191, I'm experimenting with some changes to make
Poller::addsafe.Since I'm new to I/O Safety, I probably missed something or maybe totally wrong. But I wanted to post this PR to get comments and find out what I've missed at least.
This draft change only applied on macOS, i.e.
kqueueas I'm trying to see if I was on the right direction. Thanks in advance.